[PATCH] D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/strip-underscore-default.test:8
+CHECK: __Z1fv
+CHECK: ba()
----------------
jhenderson wrote:
> compnerd wrote:
> > Can you merge this into the previous test and use -triple to test the defaults?  That ensures that the tests always run and people on other hosts can validate that they do not regress tins things.
> Sounds reasonable. I'll see what I can figure out with that.
The output of sys::getProcessTriple() is fixed (inferred from LLVM_HOST_TRIPLE).

```
static bool shouldStripUnderscore() {
  if (StripUnderscore)
    return true;
  if (NoStripUnderscore)
    return false;
  // If none of them are set, use the default value for platform.
  // macho has symbols prefix with "_" so strip by default.
  return Triple(sys::getProcessTriple()).isOSBinFormatMachO();
}
```

> UNSUPPORTED: system-darwin
> REQUIRES: system-darwin

Seem the best to test the platform differences.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71202/new/

https://reviews.llvm.org/D71202