[PATCH] D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 07:47:40 PST 2019


compnerd added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/strip-underscore-default.test:8
+CHECK: __Z1fv
+CHECK: ba()
----------------
Can you merge this into the previous test and use -triple to test the defaults?  That ensures that the tests always run and people on other hosts can validate that they do not regress tins things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71202/new/

https://reviews.llvm.org/D71202





More information about the llvm-commits mailing list