[PATCH] D71116: [test][tools] Add missing/Improve testing

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-relocations.test:1
+## Check llvm-readobj and llvm-readelf print relocations as expected.
+
----------------
This may replicate some tests in `reloc-types-elf-x64.test` but I can see that this test mostly checks format and corner case values.


================
Comment at: llvm/test/tools/llvm-readobj/elf-relocations.test:5
+# RUN: yaml2obj %s --docnum=1 -o %t64
+# RUN: llvm-readobj -r %t64 \
+# RUN:   | FileCheck %s --check-prefix=LLVM-64 --strict-whitespace --match-full-lines
----------------
Do we usually use `cmp` to test that alias options have the identical output?


================
Comment at: llvm/test/tools/llvm-readobj/elf-relocations.test:352
+Symbols:
+  - Name: rel_0
+    Section: .text
----------------
Align


================
Comment at: llvm/test/tools/llvm-symbolizer/functions.s:17
 ## input address, and just prints it.
+# RUN: llvm-symbolizer 0 -f none --obj=%t.o | FileCheck %s --check-prefixes=LINKAGE,ERR
 # RUN: llvm-symbolizer 0 --functions none --obj=%t.o | FileCheck %s --check-prefixes=LINKAGE,ERR
----------------
Unrelated to this patch.

-f can be either --functions or --functions=, and the parsing accounts for the next option. This looks strange.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71116/new/

https://reviews.llvm.org/D71116