[PATCH] D71116: [test][tools] Add missing/Improve testing

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LGTM with a nit.



================
Comment at: llvm/test/tools/llvm-readobj/elf-relocations.test:346
+        Type:   R_386_32
+        Addend: -2147483648 # Min 32-bit signed.
+      - Offset: 0x9
----------------
```
# -> ##
```
(and below)


================
Comment at: llvm/test/tools/llvm-symbolizer/functions.s:17
 ## input address, and just prints it.
+# RUN: llvm-symbolizer 0 -f none --obj=%t.o | FileCheck %s --check-prefixes=LINKAGE,ERR
 # RUN: llvm-symbolizer 0 --functions none --obj=%t.o | FileCheck %s --check-prefixes=LINKAGE,ERR
----------------
MaskRay wrote:
> Unrelated to this patch.
> 
> -f can be either --functions or --functions=, and the parsing accounts for the next option. This looks strange.
I am not sure I understood your concern.
It is just the same as `--functions none` but with the use of alias `-f`, isn't?

In another test we have a similar check:

```
# Check --obj aliases --exe, -e
# RUN: llvm-symbolizer 0xa 0xb --exe=%t.o | FileCheck %s
# RUN: llvm-symbolizer 0xa 0xb -e %t.o | FileCheck %s
# RUN: llvm-symbolizer 0xa 0xb -e=%t.o | FileCheck %s
# RUN: llvm-symbolizer 0xa 0xb -e%t.o | FileCheck %s
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71116/new/

https://reviews.llvm.org/D71116