[PATCH] D71116: [test][tools] Add missing/Improve testing

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-nm/elf-extern-only.test:5
+# RUN: llvm-nm %t.o --extern-only --no-sort | FileCheck %s
+# RUN: llvm-nm %t.o -g --no-sort | FileCheck %s
+
----------------
jhenderson wrote:
> grimar wrote:
> > I do not see `-g` in the llvm-nm`s help text.
> > Had to look at GNU.
> > (this and similar comments above are unrelated to this patch, I've put them just FTR).
> LLVM's command-line handler by default hides aliases. I don't know why. In some cases, we've explicitly marked them as not hidden, but not in others. I've got cleaning up the help text (a long way down) on my backlog, so hopefully it'll get fixed at some point.
> 
> I believe all the aliases should be in the LLVM Command Guide documentation by the way.
+1, would be nice to also see aliases grouped with the thing they're aliasing. I also have it on my list, but very far down :)


================
Comment at: llvm/test/tools/llvm-nm/elf-extern-only.test:50
+    Section: .text
\ No newline at end of file

----------------
nit: no newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71116/new/

https://reviews.llvm.org/D71116