[PATCH] D70724: [PowerPC] Add Support for indirect calls on AIX.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 6 08:29:38 PST 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5255
// place of the environment pointer.
+ assert((!hasNest || !Subtarget.isAIXABI()) &&
+ "Nest parameter is not supported on AIX.");
----------------
ZarkoCA wrote:
> I'm getting confused by this assert. Will it assert if a function has a nest parameter and it's not AIX?
> Can it be rewritten to be:
> ```
> assert((hasNest && Subtarget.isAIXABI()) && "Nest parameter is not supported on AIX.");
> ```
>
> Or am i misunderstanding something?
>
>
> Can it be rewritten to be:
> ```
> assert((hasNest && Subtarget.isAIXABI()) && "Nest parameter is not supported on AIX.");
> ```
That formulation will trigger the assert //unless// it is AIX and `hasNest` is `true`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70724/new/
https://reviews.llvm.org/D70724
More information about the llvm-commits
mailing list