[PATCH] D70724: [PowerPC] Add Support for indirect calls on AIX.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5255
   // place of the environment pointer.
+  assert((!hasNest || !Subtarget.isAIXABI()) &&
+         "Nest parameter is not supported on AIX.");
----------------
I'm getting confused by this assert. Will it assert if a function has a nest parameter and it's not AIX? 
Can it be rewritten to be: 
```
 assert((hasNest && Subtarget.isAIXABI()) && "Nest parameter is not supported on AIX.");
```

Or am i misunderstanding something? 




================
Comment at: llvm/test/CodeGen/PowerPC/aix_indirect_call.ll:1
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mattr=-altivec \
+; RUN:  -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp < %s | \
----------------
I forget whether PWR4 supports altivec,. Wondering if you need `-mattr=-altivec` here? 

I remember there was a discussion about different altivec codegen behaviour when you specify any -mcpu vs leaving it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70724/new/

https://reviews.llvm.org/D70724