[PATCH] D70724: [PowerPC] Add Support for indirect calls on AIX.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5255
   // place of the environment pointer.
+  assert((!hasNest || !Subtarget.isAIXABI()) &&
+         "Nest parameter is not supported on AIX.");
----------------
hubert.reinterpretcast wrote:
> ZarkoCA wrote:
> > I'm getting confused by this assert. Will it assert if a function has a nest parameter and it's not AIX? 
> > Can it be rewritten to be: 
> > ```
> >  assert((hasNest && Subtarget.isAIXABI()) && "Nest parameter is not supported on AIX.");
> > ```
> > 
> > Or am i misunderstanding something? 
> > 
> > 
> > Can it be rewritten to be:
> > ```
> >  assert((hasNest && Subtarget.isAIXABI()) && "Nest parameter is not supported on AIX.");
> > ```
> 
> That formulation will trigger the assert //unless// it is AIX and `hasNest` is `true`.
You're right, I blanked on the the way the assert works.  I see now it's meant to enforce that a function doesn't have nest or if it does it's not on AIX.  Please ignore my comment, Sean. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70724/new/

https://reviews.llvm.org/D70724