[PATCH] D70682: [scudo][standalone] Make tests work on Fuchsia

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad marked 3 inline comments as done.
cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:51
 
-template <uptr MaxFreeListSize = 32U> class MapAllocator {
+template <uptr MaxFreeListSize = SCUDO_FUCHSIA ? 0U : 32U> class MapAllocator {
 public:
----------------
hctim wrote:
> Can we remove this ternary-guided default? Looks like it's being manually initialised everywhere.
Stuff like `ScudoSecondaryTest, SecondaryBasic` use an default templated allocator.
I am open to gating those or leaving the ternary, as you think is better.


================
Comment at: compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:165
+#endif
 #if SCUDO_WORDSIZE == 64U
   testAllocator<scudo::FuchsiaConfig>();
----------------
hctim wrote:
> Can we now roll this up?
> 
> ```
> #if SCUDO_FUCHSIA
>   testAllocator<scudo::FuchsiaConfig>();
> #else
>   testAllocator<scudo::DefaultConfig>();
> #endif
> ```
Ack


================
Comment at: compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:219
+  UseQuarantine = false;
+#if !SCUDO_FUCHSIA
   testAllocatorThreaded<scudo::DefaultConfig>();
----------------
hctim wrote:
> Same as here
Ack


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70682/new/

https://reviews.llvm.org/D70682