[PATCH] D70682: [scudo][standalone] Make tests work on Fuchsia

[Mitch Phillips via Phabricator via llvm-commits]

hctim added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:51
 
-template <uptr MaxFreeListSize = 32U> class MapAllocator {
+template <uptr MaxFreeListSize = SCUDO_FUCHSIA ? 0U : 32U> class MapAllocator {
 public:
----------------
Can we remove this ternary-guided default? Looks like it's being manually initialised everywhere.


================
Comment at: compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:165
+#endif
 #if SCUDO_WORDSIZE == 64U
   testAllocator<scudo::FuchsiaConfig>();
----------------
Can we now roll this up?

```
#if SCUDO_FUCHSIA
  testAllocator<scudo::FuchsiaConfig>();
#else
  testAllocator<scudo::DefaultConfig>();
#endif
```


================
Comment at: compiler-rt/lib/scudo/standalone/tests/combined_test.cpp:219
+  UseQuarantine = false;
+#if !SCUDO_FUCHSIA
   testAllocatorThreaded<scudo::DefaultConfig>();
----------------
Same as here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70682/new/

https://reviews.llvm.org/D70682