[PATCH] D70682: [scudo][standalone] Make tests work on Fuchsia
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 25 15:33:15 PST 2019
hctim added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:51
-template <uptr MaxFreeListSize = 32U> class MapAllocator {
+template <uptr MaxFreeListSize = SCUDO_FUCHSIA ? 0U : 32U> class MapAllocator {
public:
----------------
cryptoad wrote:
> hctim wrote:
> > Can we remove this ternary-guided default? Looks like it's being manually initialised everywhere.
> Stuff like `ScudoSecondaryTest, SecondaryBasic` use an default templated allocator.
> I am open to gating those or leaving the ternary, as you think is better.
Personally, I am in favour of the gating of the tests rather than the ternary default.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70682/new/
https://reviews.llvm.org/D70682
More information about the llvm-commits
mailing list