[PATCH] D69956: [AArch64][SVE] Integer reduction instructions pattern/intrinsics.

Danilo Carvalho Grael via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 14:19:48 PST 2019


dancgr marked 3 inline comments as done.
dancgr added a comment.

Also the change on unrelated patterns it to avoid ambiguities in the FPR8 and FPR16 patterns.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:166
   if (Subtarget->hasSVE()) {
+    //addRegisterClass(MVT::v16i8, &AArch64::FPR8RegClass);
+    //addRegisterClass(MVT::v8i16, &AArch64::FPR16RegClass);
----------------
I will be removing both those comment lines.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:237
 
+
 };
----------------
I will be removing this unnecessary extra line.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6953
 
+
 class SIMDMovAlias<string asm, string size, Instruction inst,
----------------
I will be removing this unnecessary extra line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69956/new/

https://reviews.llvm.org/D69956





More information about the llvm-commits mailing list