[PATCH] D69332: Implement the Waymarking as an independent utility

Wed Nov 20 05:59:47 PST 2019

foad added a reviewer: foad.
foad added a comment.

I agree with @craig.topper that improving the algorithm and separating the algorithm from Use //should// be two different patches. Personally I am much more interested in the former than the latter.

Have you seen bug 6809 and read this thread: http://lists.llvm.org/pipermail/llvm-dev/2014-April/072326.html ?

Have you done any kind of profiling or measurement of your improved algorithm?

================
Comment at: llvm/docs/ProgrammersManual.rst:3157
+          '---'---'---'---'---'---'---'---'---'---'---'---'---'---'---'---'
+            -1| -2|     -4|         -7|        -10|                -14|
+           <_ |   |       |           |           |                   |
----------------
These diagrams are always confusing to read. I think it would be better to put numbers like -7 to the right of the vertical line instead of to the left; at the moment "-7" is underneath the binary encoding for 4, which is confusing. Also I think the vertical line for -14 is too far to the right. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69332/new/

https://reviews.llvm.org/D69332