[PATCH] D69332: Implement the Waymarking as an independent utility
Ehud Katz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 20 08:34:59 PST 2019
ekatz marked an inline comment as done.
ekatz added inline comments.
================
Comment at: llvm/docs/ProgrammersManual.rst:3157
+ '---'---'---'---'---'---'---'---'---'---'---'---'---'---'---'---'
+ -1| -2| -4| -7| -10| -14|
+ <_ | | | | | |
----------------
foad wrote:
> These diagrams are always confusing to read. I think it would be better to put numbers like -7 to the right of the vertical line instead of to the left; at the moment "-7" is underneath the binary encoding for 4, which is confusing. Also I think the vertical line for -14 is too far to the right.
I see what you mean. I'll change them, and fix -14.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69332/new/
https://reviews.llvm.org/D69332
More information about the llvm-commits
mailing list