[PATCH] D70407: [ARM] Generate CMSE instructions from CMSE intrinsics

[Todd Snider via Phabricator via llvm-commits]

snidertm marked 2 inline comments as done.
snidertm added a comment.

Was the "error in backend" issue mentioned in the comment above resolved?



================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4554
 
-def t2TT   : T2TT<0b00, "tt",   []>, Requires<[IsThumb,Has8MSecExt]>;
-def t2TTT  : T2TT<0b01, "ttt",  []>, Requires<[IsThumb,Has8MSecExt]>;
-def t2TTA  : T2TT<0b10, "tta",  []>, Requires<[IsThumb,Has8MSecExt]>;
-def t2TTAT : T2TT<0b11, "ttat", []>, Requires<[IsThumb,Has8MSecExt]>;
+def t2TT   : T2TT<0b00, "tt",   [(set rGPR:$Rt, (int_arm_cmse_tt   GPRnopc:$Rn))]>, Requires<[IsThumb,Has8MSecExt]>;
+def t2TTT  : T2TT<0b01, "ttt",  [(set rGPR:$Rt, (int_arm_cmse_ttt  GPRnopc:$Rn))]>, Requires<[IsThumb,Has8MSecExt]>;
----------------
dmgreen wrote:
> The Requires might be better on the next line.
Agree.


================
Comment at: llvm/test/CodeGen/ARM/intrinsics-cmse.ll:2
+; RUN: llc < %s -mtriple=thumbv8m.base -mcpu=cortex-m23 | FileCheck %s
+; RUN: llc < %s -mtriple=thumbebv8m.base -mcpu=cortex-m23 | FileCheck %s
+
----------------
Should we also add a RUN with -mcpu=cortex-m33?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70407/new/

https://reviews.llvm.org/D70407