[PATCH] D70407: [ARM] Generate CMSE instructions from CMSE intrinsics

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/intrinsics-cmse.ll:2
+; RUN: llc < %s -mtriple=thumbv8m.base -mcpu=cortex-m23 | FileCheck %s
+; RUN: llc < %s -mtriple=thumbebv8m.base -mcpu=cortex-m23 | FileCheck %s
+
----------------
snidertm wrote:
> Should we also add a RUN with -mcpu=cortex-m33?
Oh, I hadn't noticed that. Good point

It may be better to also not explicitly use a cpu. It likely doesn't matter too much for this test, but for some of the other tests with more code using the architecture only will produce less scheduling artifacts. (I guess you could argue that both should be tested too, but that can be quite verbose).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70407/new/

https://reviews.llvm.org/D70407