[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 04:39:59 PST 2019
thopre added a comment.
In D68054#1750788 <https://reviews.llvm.org/D68054#1750788>, @nlguillemot wrote:
> Removed the assert inside `match()` that made it crash when `match()` is called with a regex pattern that isn't successfully compiled. Also removed the "death test" unit tests that tested that this assert was triggering.
Can you reword the description along the line of this new API being a convenience when one does not care about distinguishing validity of a regex from whether it matches?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68054/new/
https://reviews.llvm.org/D68054
More information about the llvm-commits
mailing list