[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 16:11:04 PST 2019


nlguillemot updated this revision to Diff 229946.
nlguillemot added a comment.

Removed the assert inside `match()` that made it crash when `match()` is called with a regex pattern that isn't successfully compiled. Also removed the "death test" unit tests that tested that this assert was triggering.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68054/new/

https://reviews.llvm.org/D68054

Files:
  include/llvm/Support/Regex.h
  lib/Support/FileCheck.cpp
  lib/Support/Regex.cpp
  lib/Transforms/Utils/SymbolRewriter.cpp
  tools/llvm-cov/CoverageFilters.cpp
  unittests/Support/RegexTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68054.229946.patch
Type: text/x-patch
Size: 9314 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191119/20f95344/attachment.bin>


More information about the llvm-commits mailing list