[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"
Nicolas Guillemot via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 10:06:34 PST 2019
nlguillemot added a comment.
In D68054#1751415 <https://reviews.llvm.org/D68054#1751415>, @thopre wrote:
> In D68054#1750788 <https://reviews.llvm.org/D68054#1750788>, @nlguillemot wrote:
>
> > Removed the assert inside `match()` that made it crash when `match()` is called with a regex pattern that isn't successfully compiled. Also removed the "death test" unit tests that tested that this assert was triggering.
>
>
> Can you reword the description along the line of this new API being a convenience when one does not care about distinguishing validity of a regex from whether it matches?
Did an editing pass on the review summary to reflect the new scope of the patch, and noted what is intended as future work.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68054/new/
https://reviews.llvm.org/D68054
More information about the llvm-commits
mailing list