[PATCH] D70248: Disallow shift operations in debug expressions spanning multiple registers

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5542
+            Variable, Expr, UndefValue::get(V->getType()), DL, SDNodeOrder);
+          DAG.AddDbgValue(SDV, nullptr, false);
           continue;
----------------
This is a good change.


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1153
+      case dwarf::DW_OP_shra:
+      case dwarf::DW_OP_shl:
       case dwarf::DW_OP_plus:
----------------
This is good too, but should land in a separate, preparatory patch, tested by a unit test in `IR/MetadataTest.cpp`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70248/new/

https://reviews.llvm.org/D70248