[PATCH] D70248: Disallow shift operations in debug expressions spanning multiple registers

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/debuginfo-split-carryexpr.ll:32
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "clang version 10.0.0 (https://github.com/llvm/llvm-project.git 2f8a9f0eb221bb85164bbd81179f3a15630d24e2)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, nameTableKind: None)
+!1 = !DIFile(filename: "test.cpp", directory: "/tmp")
----------------
It is enough only producer: `"clang version 10.0.0"`.


================
Comment at: llvm/test/CodeGen/ARM/debuginfo-split-carryexpr.ll:38
+!5 = !{i32 1, !"wchar_size", i32 4}
+!6 = !{!"clang version 10.0.0 (https://github.com/llvm/llvm-project.git 2f8a9f0eb221bb85164bbd81179f3a15630d24e2)"}
+!7 = distinct !DISubprogram(name: "fn", linkageName: "_Z2fnx", scope: !8, file: !8, line: 2, type: !9, scopeLine: 2, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !12)
----------------
Same as above. (It is enough only `producer: "clang version 10.0.0"`.)


================
Comment at: llvm/test/CodeGen/ARM/debuginfo-split-carryexpr.ll:40
+!7 = distinct !DISubprogram(name: "fn", linkageName: "_Z2fnx", scope: !8, file: !8, line: 2, type: !9, scopeLine: 2, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !12)
+!8 = !DIFile(filename: "./most.cpp", directory: "/home/stozer/dev/llvm-project")
+!9 = !DISubroutineType(types: !10)
----------------
`test.cpp, /tmp`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70248/new/

https://reviews.llvm.org/D70248