[PATCH] D68984: [MIPS GlobalISel] Select MSA vector generic and builtin add

[Petar Avramovic via Phabricator via llvm-commits]

Petar.Avramovic marked 2 inline comments as done.
Petar.Avramovic added inline comments.


================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:44
 
+template <int T>
+inline bool CheckTy(const LegalityQuery &Query,
----------------
atanasyan wrote:
> Are there any advantages of passing the `T` as a template parameter instead of a regular function argument with more mnemonic name?
Not that I am aware of. Then change it to:
bool CheckTyN(unsigned N, const LegalityQuery &Query, std::initializer_list<LLT> SupportedValues) ?



================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:55
+
+class IsTyAtIdxVectorAndSTDoesntHaveMSA {
+private:
----------------
atanasyan wrote:
> Do you use this class anywhere?
Missed that, it was meant to be used later for scalarize, will remove it for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68984/new/

https://reviews.llvm.org/D68984