[PATCH] D68984: [MIPS GlobalISel] Select MSA vector generic and builtin add

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:44
 
+template <int T>
+inline bool CheckTy(const LegalityQuery &Query,
----------------
Are there any advantages of passing the `T` as a template parameter instead of a regular function argument with more mnemonic name?


================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:48
+  for (auto &Val : SupportedValues) {
+    if (Val != Query.Types[T])
+      continue;
----------------
It can be written a bit shorter:
```
if (Val == Query.Types[T])
  return true;
```


================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:55
+
+class IsTyAtIdxVectorAndSTDoesntHaveMSA {
+private:
----------------
Do you use this class anywhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68984/new/

https://reviews.llvm.org/D68984