[PATCH] D68984: [MIPS GlobalISel] Select MSA vector generic and builtin add

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/Mips/MipsLegalizerInfo.cpp:44
 
+template <int T>
+inline bool CheckTy(const LegalityQuery &Query,
----------------
Petar.Avramovic wrote:
> atanasyan wrote:
> > Are there any advantages of passing the `T` as a template parameter instead of a regular function argument with more mnemonic name?
> Not that I am aware of. Then change it to:
> bool CheckTyN(unsigned N, const LegalityQuery &Query, std::initializer_list<LLT> SupportedValues) ?
> 
> Then change it to: `bool CheckTyN(unsigned N, const LegalityQuery &Query, std::initializer_list<LLT> SupportedValues)` ?

Yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68984/new/

https://reviews.llvm.org/D68984