[PATCH] D68833: [CMake] Re-order runtimes in the order of dependencies

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

Two thoughts.

(1) Short term I think this is wrong, in general we should avoid using `if(TARGET...)`. Compiler-rt has the most ridiculous magic in it for which targets are enabled or not, which is why it was put first. That allows the other runtimes to check against compiler-rt which was harder to replicate logic for which sanitizers were included in the build. The other runtime libraries should be able to use the `HAVE_${runtime}` variables to determine the presence of the other runtimes. That should correctly allow libcxx, libcxxabi and libunwind to not be order dependent. 
(2) Longer term, we really need to update the runtimes to make their dependencies based on generator expressions so that we can remove at least some of the order dependence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68833/new/

https://reviews.llvm.org/D68833