[PATCH] D68833: [CMake] Re-order runtimes in the order of dependencies
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 10 20:25:57 PDT 2019
compnerd added a comment.
I feel like Im not understanding something. The point of CMake is that it tracks dependencies. We are we manually tracking dependencies?
The `MSAN` check was needed due to the inverted dependencies; with unified builds, this shouldnt be an issue any longer. I think that propagating the checks this way is the wrong approach.
Can you please explain why you need the `if(TARGET runtime)` in the first place? Understanding that might help with coming up with a better solution (or possibly an existing solution).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68833/new/
https://reviews.llvm.org/D68833
More information about the llvm-commits
mailing list