[PATCH] D68833: [CMake] Re-order runtimes in the order of dependencies

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Makes sense to me, particularly since this is generalizing what we're already doing for compiler-rt.

Is compiler-rt's place in the dependency list accurate though? For example, libc++ needs a builtins library, which could be compiler-rt, and I think the compiler-rt to libc++ dependency is limited to things like libFuzzer. I don't think libc++ supports using an in-tree compiler-rt though, so that's probably a moot point.



================
Comment at: llvm/runtimes/CMakeLists.txt:113
 
+  # Re-order runtimes in the order of dependencies: libcxxabi depend on libunwind,
+  # libcxx depends on libcxxabi, some compiler-rt runtimes depend on libcxx. This
----------------
depend on -> depends on


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68833/new/

https://reviews.llvm.org/D68833