[PATCH] D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine marked an inline comment as done.
saugustine added inline comments.


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:1
+; RUN: llc -mtriple=x86_64-linux-gnu - < %s -o -
+
----------------
arsenm wrote:
> RKSimon wrote:
> > RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s
> > 
> > And then run the file through the utils/update_llc_test_checks.py script
> This is not a GlobalISel test, and should not go in the GlobalISel directory
Where should it go?

I'm inclined just to drop the test case altogether. Most of the other code paths that needed the switch from getConstant to getTargetConstant don't have test cases either.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67850/new/

https://reviews.llvm.org/D67850