[PATCH] D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:1
+; RUN: llc -mtriple=x86_64-linux-gnu - < %s -o -
+
----------------
RKSimon wrote:
> RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s
> 
> And then run the file through the utils/update_llc_test_checks.py script
This shouldn't be in the GlobalISel directory. It doesn't enable GlobalIsel.


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:1
+; RUN: llc -mtriple=x86_64-linux-gnu - < %s -o -
+
----------------
saugustine wrote:
> arsenm wrote:
> > craig.topper wrote:
> > > RKSimon wrote:
> > > > RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s
> > > > 
> > > > And then run the file through the utils/update_llc_test_checks.py script
> > > This shouldn't be in the GlobalISel directory. It doesn't enable GlobalIsel.
> > This is not a GlobalISel test, and should not go in the GlobalISel directory
> Where should it go?
> 
> I'm inclined just to drop the test case altogether. Most of the other code paths that needed the switch from getConstant to getTargetConstant don't have test cases either.
> 
It can just go in test/CodeGen/X86.  That's where all the SelectionDAG based tests are. Only tests that enable the non-default global instruction selection should be in the GlobalISel subdirectory.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67850/new/

https://reviews.llvm.org/D67850