[PATCH] D67196: [Verifier] add invariant check for callbr

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 15:48:03 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll:1-4
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -filetype=obj -o - \
 ; RUN:  | llvm-objdump -triple aarch64-unknown-linux-gnu -d - \
 ; RUN:  | FileCheck %s
----------------
nickdesaulniers wrote:
> lebedev.ri wrote:
> > Does `update_llc_test_checks` actually deal with this chaining?
> > I don't believe it does.
> It does not, hence why I wasn't able to run `./llvm/utils/update_llc_test_checks.py llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll`and then observe any changes to the file (other than the header, which I see I committed accidentally).  Do you know how I would fix the chaining related issue?
By manually updating the check lines i suppose. I hate doing that :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67196/new/

https://reviews.llvm.org/D67196





More information about the llvm-commits mailing list