[PATCH] D67196: [Verifier] add invariant check for callbr

Wed Sep 4 15:41:05 PDT 2019

nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.

In D67196#1658509 <https://reviews.llvm.org/D67196#1658509>, @lebedev.ri wrote:

> Is this already documented in LangRef?

It is not!
https://llvm.org/docs/LangRef.html#callbr-instruction
Shall I add to that in this patch? (Assuming it's ok to explicitly state such an invariant?)

================
Comment at: llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll:1-4
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -filetype=obj -o - \
 ; RUN:  | llvm-objdump -triple aarch64-unknown-linux-gnu -d - \
 ; RUN:  | FileCheck %s
----------------
lebedev.ri wrote:
> Does `update_llc_test_checks` actually deal with this chaining?
> I don't believe it does.
It does not, hence why I wasn't able to run `./llvm/utils/update_llc_test_checks.py llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll`and then observe any changes to the file (other than the header, which I see I committed accidentally).  Do you know how I would fix the chaining related issue?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67196/new/

https://reviews.llvm.org/D67196