[PATCH] D67196: [Verifier] add invariant check for callbr

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 15:57:00 PDT 2019


srhines added inline comments.


================
Comment at: llvm/test/Verifier/callbr.ll:2
+; RUN: not opt -S %s -verify 2>&1 | FileCheck %s
+
+; CHECK: Indirect label missing from arglist.
----------------
Can you add a test case that shows the proper subset behavior (i.e. more blockaddress labels than are handled by the indirect label list)?

Can you also flip the labels in one test case so that you aren't just iterating over the same exact labels in the same exact order in both places (i.e. verify set behavior rather than just simple iteration).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67196/new/

https://reviews.llvm.org/D67196





More information about the llvm-commits mailing list