[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 15:27:14 PDT 2019


cishida added inline comments.


================
Comment at: llvm/trunk/tools/llvm-ifs/llvm-ifs.cpp:238
+  File.setArchitectures(Arch);
+  File.setPlatform(PlatformKind::macOS);
+
----------------
I apologize for commenting on this retroactively, but if this hardcoded value is related to the experimental support for TBD files, I think there should be a comment detailing it. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405





More information about the llvm-commits mailing list