[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 2 inline comments as done.
plotfi added inline comments.


================
Comment at: llvm/trunk/tools/llvm-ifs/llvm-ifs.cpp:238
+  File.setArchitectures(Arch);
+  File.setPlatform(PlatformKind::macOS);
+
----------------
cishida wrote:
> I apologize for commenting on this retroactively, but if this hardcoded value is related to the experimental support for TBD files, I think there should be a comment detailing it. 
Ah yeah, thanks for bringing this up @cishida. I’ll try and at the very least add some more comments on this soon. For now I’m still working on wiring up the clang driver and ifs generation to llvm-ifs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405