[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked an inline comment as done.
plotfi added inline comments.


================
Comment at: llvm/trunk/test/lit.cfg.py:25
 # by individual lit.local.cfg files in the test subdirectories.
 config.suffixes = ['.ll', '.c', '.cxx', '.test', '.txt', '.s', '.mir']
 
----------------
thakis wrote:
> thakis wrote:
> > Since this list doesn't contain ".ifs", none of the tests you added actually run as part of `check-llvm`. I'd recommend renaming the tests to ".test" instead of adding ".ifs" to this list.
> A possibly even better fix is to add `test/tools/llvm-ifs/lit.local.cfg` that does `config.suffixes = ['.ifs']`. See e.g. `llvm/test//TableGen/lit.local.cfg` for an example.
Thank you for this heads up Nico. I'll land something shortly. I like the config.suffixes approach. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405