[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 23:04:06 PDT 2019


atanasyan added a comment.

I would prefer always passing MCTargetOptions to MCAsmInfo too. Could you try this approach? But take a look at `LLVMCreateDisasmCPUFeatures` function from `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this function, we will have to change "LLVM-C" interface `LLVMCreateDisasmCPUFeatures` function. There is an interesting comment in the D20916 <https://reviews.llvm.org/D20916> - "Why not use MCTargetOptions::ABIName".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795





More information about the llvm-commits mailing list