[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added a comment.
Herald added a subscriber: wuzish.

In D66795#1647294 <https://reviews.llvm.org/D66795#1647294>, @arichardson wrote:

> If you remove the default argument from `createMCAsmInfo`, how many files need to explicitly pass nullptr/None?


In LLVM there are 13 files and also a couple more in Clang:

Search results in case you're interested.

llvm/lib/MC/MCDisassembler/Disassembler.cpp:60
`  std::unique_ptr<const MCAsmInfo> MAI(TheTarget->createMCAsmInfo(*MRI, TT));`
llvm/lib/Object/ModuleSymbolTable.cpp:86
`  std::unique_ptr<MCAsmInfo> MAI(T->createMCAsmInfo(*MRI, TT.str()));`
llvm/tools/llvm-cfi-verify/lib/FileAnalysis.cpp:390
`  AsmInfo.reset(ObjectTarget->createMCAsmInfo(*RegisterInfo, TripleName)); `
llvm/tools/sancov/sancov.cpp:818
`  std::unique_ptr<const MCAsmInfo> AsmInfo(`
`      TheTarget->createMCAsmInfo(*MRI, TripleName));     `
llvm/tools/llvm-rtdyld/llvm-rtdyld.cpp:726
`  std::unique_ptr<MCAsmInfo> MAI(TheTarget->createMCAsmInfo(*MRI, TripleName));`
llvm/tools/llvm-objdump/llvm-objdump.cpp:1506
`  std::unique_ptr<const MCAsmInfo> AsmInfo(`
`      TheTarget->createMCAsmInfo(*MRI, TripleName)); `
llvm/tools/llvm-objdump/MachODump.cpp:7215:
`  std::unique_ptr<const MCAsmInfo> AsmInfo(`
`    TheTarget->createMCAsmInfo(*MRI, TripleName));   `
llvm/tools/llvm-objdump/MachODump.cpp:7265:
`  ThumbAsmInfo.reset(`
`      ThumbTarget->createMCAsmInfo(*ThumbMRI, ThumbTripleName));`
llvm/tools/llvm-mca/llvm-mca.cpp:351
`  std::unique_ptr<MCAsmInfo> MAI(TheTarget->createMCAsmInfo(*MRI, TripleName));`
llvm/tools/llvm-exegesis/lib/Analysis.cpp:174
`  AsmInfo_.reset(Target.createMCAsmInfo(*RegInfo_, FirstPoint.LLVMTriple));`
llvm/tools/llvm-jitlink/llvm-jitlink.cpp:526
`  std::unique_ptr<MCAsmInfo> MAI(TheTarget->createMCAsmInfo(*MRI, TripleName));`
llvm/unittests/ExecutionEngine/JITLink/JITLinkTestCommon.cpp:62
`  MAI.reset(TheTarget->createMCAsmInfo(*MRI, TT.getTriple()));`
llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp:412
`  MAI.reset(TheTarget->createMCAsmInfo(*MRI, TripleName));`
llvm/unittests/MC/DwarfLineTables.cpp:40  
`    MAI.reset(TheTarget->createMCAsmInfo(*MRI, Triple));`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795