[PATCH] D53137: Scalable vector core instruction support + size queries

[Graham Hunter via Phabricator via llvm-commits]

huntergr updated this revision to Diff 217354.
huntergr added a comment.

- Split out backend code into separate patches
- Renamed 'Min' to 'KnownMin' in method names.
- Added a few more comments.

I tried to replace the comparison of minimum sizes to 0 in Instructions.cpp (for the bitcast checks), but that statement represents quite a lot. Could be scalar pointers, could be a vector of pointers (both of which I checked for in experiments), but there are several other types which report a size of 0 and which are checked for in some unit tests, so the number of checks ended up being fairly substantial. I've left it alone for now, but if reviewers would prefer I extract a method to explicitly check for all conditions represented by the size check I can do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53137/new/

https://reviews.llvm.org/D53137

Files:
  llvm/include/llvm/IR/DataLayout.h
  llvm/include/llvm/IR/InstrTypes.h
  llvm/include/llvm/IR/Type.h
  llvm/include/llvm/Support/ScalableSize.h
  llvm/lib/IR/DataLayout.cpp
  llvm/lib/IR/Instructions.cpp
  llvm/lib/IR/Type.cpp
  llvm/test/Other/scalable-vectors-core-ir.ll
  llvm/unittests/IR/VectorTypesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53137.217354.patch
Type: text/x-patch
Size: 39084 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190827/f115f0c7/attachment-0001.bin>