[PATCH] D66766: [SampleFDO] Add symbol whitelist section to discriminate function being cold versus function being newly added

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/ProfileData/SampleProf.cpp:222
+  SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end());
+  std::sort(SortedList.begin(), SortedList.end());
+
----------------
Please use the range-based llvm::sort here.
```
llvm::sort(SortedList);
```


================
Comment at: lib/ProfileData/SampleProf.cpp:245
+  SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end());
+  std::sort(SortedList.begin(), SortedList.end());
+
----------------
Please use the range-based llvm::sort here.
```
llvm::sort(SortedList);
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66766/new/

https://reviews.llvm.org/D66766