[PATCH] D66766: [SampleFDO] Add symbol whitelist section to discriminate function being cold versus function being newly added

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 17:11:13 PDT 2019


wmi updated this revision to Diff 217745.
wmi added a comment.

Address David and Mandeep's comments.

Add symbol whitelist support in llvm-profdata. It supports reading in a text format symbols list and adding it to a profile. The output profile has to be ExtBinary format. llvm-profdata can control whether the symbol whitelist will be compressed or not, and whether it will be shown when dumping the profile.

With llvm-profdata, profile with symbol-whitelist used for testing can be generated given an existing text format profile and a text symbol list.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66766/new/

https://reviews.llvm.org/D66766

Files:
  include/llvm/ProfileData/SampleProf.h
  include/llvm/ProfileData/SampleProfReader.h
  include/llvm/ProfileData/SampleProfWriter.h
  lib/ProfileData/SampleProf.cpp
  lib/ProfileData/SampleProfReader.cpp
  lib/ProfileData/SampleProfWriter.cpp
  lib/Transforms/IPO/SampleProfile.cpp
  test/Transforms/SampleProfile/Inputs/symbol-whitelist.text
  test/Transforms/SampleProfile/compressed-symbol-white-list.ll
  test/Transforms/SampleProfile/uncompressed-symbol-white-list.ll
  test/tools/llvm-profdata/Inputs/symbol-whitelist-1.text
  test/tools/llvm-profdata/Inputs/symbol-whitelist-2.text
  test/tools/llvm-profdata/Inputs/symbol-whitelist.expected
  test/tools/llvm-profdata/symbol-white-list.test
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/SampleProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66766.217745.patch
Type: text/x-patch
Size: 41542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190829/65546641/attachment.bin>


More information about the llvm-commits mailing list