[PATCH] D66766: [SampleFDO] Add symbol whitelist section to discriminate function being cold versus function being newly added

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/ProfileData/SampleProf.cpp:231
+  SmallString<128> CompressedStrings;
+  llvm::Error E = zlib::compress(UncompressedStrings, CompressedStrings,
+                                 zlib::BestSizeCompression);
----------------
Check zlib::isAvailable() -- if it returns false, do not do compression.

It is also better to add an internal option to disable compression.


================
Comment at: test/Transforms/SampleProfile/symbol-white-list.ll:4
+
+; Original C++ test case
+;
----------------
The test would fail on platforms without zlib. Need to use REQUIRE to limit the test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66766/new/

https://reviews.llvm.org/D66766