[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 18:04:28 PDT 2019
aheejin added a comment.
In D64776#1586697 <https://reviews.llvm.org/D64776#1586697>, @aheejin wrote:
> - Not sure what this means. The CL description says it tries to compile things into local-exec, but what this CL does look like checking if a global var is local-exec and if not report an error.
> - What is supposed to happen when the OS is not emscripten? If we don't support TLS in non-emscripten OSes regardless of its mode (local-exec or not), should we print an error in that case too?
> - Also, a test would be good too.
Uh, not sure if you saw the comments?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64776/new/
https://reviews.llvm.org/D64776
More information about the llvm-commits
mailing list