[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec

[Guanzhong Chen via Phabricator via llvm-commits]

quantum marked 2 inline comments as done.
quantum added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:184
+    // with threads. Therefore, if we have thread-local storage, only the
+    // local-exec model is possible.
     if (GA->getGlobal()->getThreadLocalMode() !=
----------------
aheejin wrote:
> If this condition is to be removed once emscripten support dynamic linking with threads, rather than `XXX`, how about marking as `TODO Remove this condition once emscripten supports dynamic linking with threads` or something?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64776/new/

https://reviews.llvm.org/D64776