[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec

[Guanzhong Chen via Phabricator via llvm-commits]

quantum updated this revision to Diff 210137.
quantum marked an inline comment as done.
quantum added a comment.

In D64776#1586697 <https://reviews.llvm.org/D64776#1586697>, @aheejin wrote:

> - Not sure what this means. The CL description says it tries to compile things into local-exec, but what this CL does look like checking if a global var is local-exec and if not report an error.
> - What is supposed to happen when the OS is not emscripten? If we don't support TLS in non-emscripten OSes regardless of its mode (local-exec or not), should we print an error in that case too?
> - Also, a test would be good too.




- On Emscripten, the code does not report an error if the variable is not local-exec and instead compiles it as local-exec.
- The local-exec implementation should still theoretically work for other embeddings. Only the idea that only local-exec is currently possible is emscripten-specific.
- A test is added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64776/new/

https://reviews.llvm.org/D64776

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp
  llvm/test/CodeGen/WebAssembly/tls-general-dynamic.ll
  llvm/test/CodeGen/WebAssembly/tls-local-exec.ll
  llvm/test/CodeGen/WebAssembly/tls.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64776.210137.patch
Type: text/x-patch
Size: 5733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190716/873607b6/attachment.bin>