[PATCH] D64623: [gn] Tag unneeded variable.

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:388
+    } else {
+      not_needed(invoker, [ "value" ])
     }
----------------
nit: I'd keep the loop out of the if and do

```
  if (all_targets == []) {
    not_needed(invoker, [ "value" ])
  }
``

after the loop instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64623/new/

https://reviews.llvm.org/D64623