[PATCH] D64623: [gn] Tag unneeded variable.

[bryant via Phabricator via llvm-commits]

bryant created this revision.
bryant added reviewers: thakis, phosek.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When only building targets without assembly parsers (e.g.,
`llvm_targets_to_build = ["NVPTX"]`), `all_targets` is empty and causes GN to
warn about an assigned-but-unused variable.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64623

Files:
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
@@ -380,8 +380,12 @@
     # that \n is a literal '\' followed by a literal 'n', not a newline
     # character.  (write_cmake_config.py replaces that with a real newline).
     value = ""
-    foreach(target, all_targets) {
-      value = "$value${invoker.value}($target)\n"
+    if (all_targets != []) {
+      foreach(target, all_targets) {
+        value = "$value${invoker.value}($target)\n"
+      }
+    } else {
+      not_needed(invoker, [ "value" ])
     }
     values = [ "${invoker.key}=$value" ]
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64623.209434.patch
Type: text/x-patch
Size: 770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/75e2c6d2/attachment.bin>