[PATCH] D64623: [gn] Tag unneeded variable.

[bryant via Phabricator via llvm-commits]

bryant updated this revision to Diff 209471.
bryant added a comment.

Moved for-loop out of branch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64623/new/

https://reviews.llvm.org/D64623

Files:
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
@@ -383,6 +383,9 @@
     foreach(target, all_targets) {
       value = "$value${invoker.value}($target)\n"
     }
+    if (all_targets == []) {
+      not_needed(invoker, [ "value" ])
+    }
     values = [ "${invoker.key}=$value" ]
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64623.209471.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/0435e772/attachment.bin>