[PATCH] D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 08:47:14 PDT 2019
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: test/MC/WebAssembly/basic-assembly.s:91
.section .rodata..L.str,"",@
+ .hidden .L.str
.L.str:
----------------
Align second column with line above?
================
Comment at: test/MC/WebAssembly/basic-assembly.s:179
# CHECK: .section .rodata..L.str,"",@
+# CHECK-NEXT: .hidden .L.str
# CHECK-NEXT:.L.str:
----------------
Indentation looks great than directives below?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63901/new/
https://reviews.llvm.org/D63901
More information about the llvm-commits
mailing list