[PATCH] D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser.

Thu Jun 27 16:29:05 PDT 2019

dschuff added inline comments.

================
Comment at: lib/MC/MCParser/WasmAsmParser.cpp:233
+    MCSymbolAttr Attr = StringSwitch<MCSymbolAttr>(Directive)
+      .Case(".weak", MCSA_Weak)
+      .Case(".local", MCSA_Local)
----------------
@sbc100 do we support exactly the same set of visibility types as ELF? I think the answer is no, right? In that case it probably also answers the question of whether we can share code with ELF too.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63901/new/

https://reviews.llvm.org/D63901