[PATCH] D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser.

Fri Jun 28 08:47:24 PDT 2019

sbc100 added a comment.

I'm sad to see more code duplication but OK with adding along with the TODO to find a better way.

================
Comment at: lib/MC/MCParser/WasmAsmParser.cpp:233
+    MCSymbolAttr Attr = StringSwitch<MCSymbolAttr>(Directive)
+      .Case(".weak", MCSA_Weak)
+      .Case(".local", MCSA_Local)
----------------
dschuff wrote:
> @sbc100 do we support exactly the same set of visibility types as ELF? I think the answer is no, right? In that case it probably also answers the question of whether we can share code with ELF too.
Technically we don't support "protected" yet, but there is no reason why we shouldn't in the future.   Even though we don't support it its not clear to me if we should generate an error here, or perhaps in EmitSymbolAttribute?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63901/new/

https://reviews.llvm.org/D63901